-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33 firebase error handler #35
Conversation
Pull Request Test Coverage Report for Build 204156602
💛 - Coveralls |
Hey mate! Just having a look through now.
It's so we can inject mock services into the MyApp widget - either in a widget test where the widget under test is MyApp (so effectively the whole app) or in integration tests.
What specifically do you want me to test? What error message code are you expecting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great man, awesome work!!!
@tamari-gray just to follow up on the exceptions question, the exceptions are (as far as I understand) consistent across platforms since flutter/plugins#775 and apparently are being improved to use types: firebase/flutterfire#2653 |
@nickmeinhold thanks so much for the detailed comments/ explanations & feedback! |
fixes #33
Hi nick, went out of scope of ticket by implementing firebase error handling in signinscreen.
I did that so i could write tests for it.
i also had to touch the main,dart file, setting a navService in main(), and feeding the navigaorKey to myapp.
cant remember why we made the authservice in the main() function and not my app but i dont doubt theres a good reason haha.
and i updated the classes in your test files, if the ci tests pass, then im a lucky man.
Not sure if will work on ios