parameterise backup frequency to be user input #22
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arulrajnet
reviewed
Aug 5, 2024
Dockerfile
Outdated
| @@ -22,10 +22,19 @@ RUN chmod +x /usr/local/bin/dockerize | |||
| ARG GIT_COMMIT_ID=unspecified | |||
| ENV GIT_COMMIT_ID=$GIT_COMMIT_ID | |||
|
|
|||
| # Target frequencies needed. Make them true from docker compose. | |||
|
|
|||
| ENV SCHEDULE_BACKUP_HOURLY "false" | |||
There was a problem hiding this comment.
@vijayabharathib can we set this as true by default?
arulrajnet
reviewed
Aug 5, 2024
| @@ -11,3 +11,8 @@ MYSQL_PORT="3306" | |||
| MYSQL_USER="root" | |||
| MYSQL_PASSWORD="secret" | |||
| MYSQLDUMP_DATABASE="my_wiki" | |||
| # specify the frequencies needed | |||
There was a problem hiding this comment.
@vijayabharathib Here this has to be like key=value format.
SCHEDULE_BACKUP_HOURLY="true"
like the above
arulrajnet
requested changes
Aug 5, 2024
arulrajnet
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #20