fix(serve): fix a small bug in request header validation

In the case that an incoming request header was an array, it always would have been seen as invalid
due to a typo

.eslintrc

@@ -10,8 +10,7 @@
   "plugins": ["@typescript-eslint", "jest", "prettier"],
   "extends": [
     "plugin:@typescript-eslint/recommended",
-    "prettier/@typescript-eslint",
-    "plugin:prettier/recommended"
+    "prettier/@typescript-eslint"
   ],
   "rules": {
     "no-unused-expressions": "off",

src/commands/serve/server/header-validator.spec.ts

@@ -13,7 +13,7 @@ describe('areHeadersValid', () => {
     const result = areHeadersValid(expected, {
       'X-Hello': 'world',
       'what-is': 'love',
-      baby: ['dont', 'hurt', 'me'],
+      baby: ['dont', 'me', 'hurt'],
     })
 
     expect(result).toMatchObject<HeaderValidationResult>({ success: true })
@@ -28,8 +28,22 @@ describe('areHeadersValid', () => {
 
     const result = areHeadersValid(expected, {
       Hello: 'world',
-      'what-is': 'Love',
-      baby: ['dont', 'hurt', 'me'],
+      'what-is': 'love',
+      baby: ['dont', 'hurt'],
+    })
+
+    expect(result).toMatchObject<HeaderValidationResult>({
+      success: false,
+    })
+  })
+
+  it('returns false if there are multiple received header values that do not match', () => {
+    const expected = {
+      hello: 'world',
+    }
+
+    const result = areHeadersValid(expected, {
+      hello: ['werld', 'peace'],
     })
 
     expect(result).toMatchObject<HeaderValidationResult>({

src/commands/serve/server/header-validator.ts

@@ -24,21 +24,21 @@ export const areHeadersValid = (
 
   for (const key in expectedHeaders) {
     const expected = expectedHeaders[key]
-    const actual = receivedHeaders[key]
+    const received = receivedHeaders[key]
     const badResult = { success: false }
 
     if (expected.includes(',')) {
-      if (!Array.isArray(actual)) return badResult
+      if (!Array.isArray(received)) return badResult
       for (const item of expected.split(',')) {
-        if (!actual.includes(item)) return badResult
+        if (!received.includes(item)) return badResult
       }
       break
     }
 
-    if (Array.isArray(receivedHeaders)) {
-      if (!actual?.includes(expected)) return badResult
+    if (Array.isArray(received)) {
+      if (!received?.includes(expected)) return badResult
     } else {
-      if (actual !== expected) return badResult
+      if (received !== expected) return badResult
     }
   }