fix: Deposits #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .envrc: Language not supported
- flake.nix: Language not supported
- src/TangleLiquidRestakingVault.sol: Language not supported
- test/TangleLiquidRestakingVault.t.sol: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:41
- [nitpick] The 'forge soldeer update -d' command is used twice in the workflow. Consider optimizing to avoid redundancy.
run: forge soldeer update -d
LCOV of commit
|
shekohex
added a commit
to tangle-network/tangle
that referenced
this pull request
Jan 14, 2025
Related to: tangle-network/lrt#1
drewstone
approved these changes
Jan 14, 2025
drewstone
pushed a commit
to tangle-network/tangle
that referenced
this pull request
Jan 21, 2025
* feat: LRTs * fix: Update precompiles bytecode to get around the EVM checks As precompiles are implemented inside the Runtime, they don't have a bytecode, and their account code is empty by default. However in Solidity calling a function of a contract often automatically adds a check that the contract bytecode is non-empty. For that reason a dummy code (0x60006000fd) can be inserted at the precompile address to pass that check. * fix: LRT deposit workflow Related to: tangle-network/lrt#1 * chore: Expose the precompiles as type alias * fix: Update LRT Test * feat: LRT withdraw works * chore: fix clippy * Discard changes to precompiles/multi-asset-delegation/src/lib.rs * Discard changes to runtime/testnet/src/precompiles.rs * feat: add LRT rewards test * chore: debugging the issue with unstaking * feat: add balanceOf calls to the precompile * fix: make balanceOf view calls * chore: remove logging * fix: update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several important updates to the development environment, CI workflow, Solidity contracts, and test calculations. The most significant changes include the addition of a Nix flake file, updates to the GitHub Actions workflow, and modifications to the Solidity contract and its associated tests.
CI Workflow:
.github/workflows/test.ymlto include branch-specific triggers, concurrency control, and an additional job for generating a coverage report. [1] [2]Solidity Contracts:
foundry.tomlto specify the Solidity compiler version and optimizer settings.src/TangleLiquidRestakingVault.solto include a new import statement and refactored theaddRewardTokenanddepositfunctions for better readability and functionality. [1] [2] [3]Test Calculations:
test/TangleLiquidRestakingVault.t.solfor clarity and correctness. [1] [2]