Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat&fix(支持私有页面的数据访问): 使用react-notion-x要求的方式进行NotionAPI的配置 #3082

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

qixing-jk
Copy link
Contributor

(cherry picked from commit d5ae329)

尽量按此模板PR内容,或粘贴相关的ISSUE链接。

已知问题

  1. 现有Notion不公开部署方式无法使用

解决方案

  1. 根据原有react-notion-x的指南进行修改
  2. 统一获取API对象的方式

改动收益

  1. 支持从不公开Notion获取,但存在无法正确加载图片等文件的问题,react-notion-x也放弃了支持,根本想要实现还是得更换为私人页面从Notion官方JS SDK进行获取

具体改动

  1. 详见commits

测试确认

  • 本地开发环境测试通过
  • 生产环境构建测试通过
  • 版本号正确显示
  • 环境变量配置正常工作

Copy link

vercel bot commented Dec 23, 2024

@qixing-jk is attempting to deploy a commit to the tangly1024's projects Team on Vercel.

A member of the Team first needs to authorize it.

@tangly1024
Copy link
Owner

由于图片和文件的问题存在,暂时放弃对私有Notion的支持

@qixing-jk
Copy link
Contributor Author

由于图片和文件的问题存在,暂时放弃对私有Notion的支持

私有page这个情况我也不乐意用,但是pull request后起码能用,比现在直接报错要好一些吧

@tangly1024 tangly1024 merged commit 707a686 into tangly1024:main Jan 1, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants