Add OPEN_FULLMUTEX flag when opening mbtiles #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to sqlitecpp-new-version
…ncy" This reverts commit 8e6d471.
|
Hey @rwrx, thanks for your patience with this PR! The change to update SQLiteCpp and apply the OPEN_FULLMUTEX flag looks good. I tried reverting the CMake changes because the iOS build was working on my machine without those flags. I think there may be a bug in CMake 3.17 related to iOS builds because it works fine using CMake 3.18. |
|
@matteblair ok, I understand, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android without this flag showing maps from mbtiles works properly as somewhere I read that on Android SQLite is opened with thread-safety, but unfortunately on iOS without this flag showing maps from mbtiles crashes, so this adds thread-safety for iOS devices.