More consistent interface for converting between screen and geographic coordinates #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,12 +88,11 @@ float getTilt(); | |||
|
|
|||
| // Transform coordinates in screen space (x right, y down) into their longitude | |||
| // and latitude in the map view | |||
There was a problem hiding this comment.
Can you update the comments here to reflect (lng, lat) pair has the appropriate value. Currently if one just reads the comments it seems x and y will be transformed/updated to have lng/lat respectively.
matteblair
force-pushed
the
screen2lonlat2screen
branch
from
caeb93e to
89a2991
Compare
|
Updated with improved comments and one more commit. |
|
Looks good to me. Merging. |
|
One question first! |
|
Ok, last issue resolved, should be good to go! |
| @@ -379,12 +379,15 @@ public CameraType getCameraType() { | |||
| /** | |||
| * Find the geographic coordinates corresponding to the given position on screen | |||
| * @param screenPosition Position in pixels from the top-left corner of the map area | |||
| * @return LngLat corresponding to the given point | |||
| * @return LngLat corresponding to the given point, or null if the screen position | |||
| * does not intersect a geographic location. | |||
There was a problem hiding this comment.
We can mention "or null if the screen position does not intersect a geographic location, which can happen at higher tilt angles".
matteblair
force-pushed
the
screen2lonlat2screen
branch
from
a70362b to
c550df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses consistent types and naming for the relevant function calls. It should be obvious that these functions are the inverse of one another.
lngLatToScreenPositionreturnstrueif the point is visible (the opposite of the old behavior). This is a more subjective point but to me it seems much more intuitive to associate a "positive" result with something being visible, e.g. the following use case seems reasonable:screenPositionToLngLatreturnstrueif the screen position corresponds to a geographic location (i.e. if the ray cast has a positive intersection). This is meaningful information for tilted views.