Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making worker catch assertions errors #20

Merged
merged 1 commit into from
Mar 13, 2013
Merged

Making worker catch assertions errors #20

merged 1 commit into from
Mar 13, 2013

Conversation

narkisr
Copy link
Contributor

@narkisr narkisr commented Mar 13, 2013

This is a tiny fix in which throwable is catched, without this assertion errors (like in :pre) cause the work to die silently the background (took me some time to find)

ptaoussanis added a commit that referenced this pull request Mar 13, 2013
Making worker catch assertions errors
@ptaoussanis ptaoussanis merged commit 3f9dba0 into taoensso:master Mar 13, 2013
@ptaoussanis
Copy link
Member

Great Ronen, thanks! Just a heads-up, I may not be able to take a look at the lock ns for another day or two - will keep you updated.

@narkisr
Copy link
Contributor Author

narkisr commented Mar 13, 2013

That's cool
On Mar 13, 2013 8:24 AM, "Peter Taoussanis" [email protected]
wrote:

Great Ronen, thanks! Just a heads-up, I may not be able to take a look at
the lock ns for another day or two - will keep you updated.


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-14826516
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants