Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mikera/vectorz to thaw allowlist #139

Closed
wants to merge 1 commit into from

Conversation

danielfleischer
Copy link

No description provided.

@ptaoussanis
Copy link
Member

Hi there! Has someone verified that all the targeted classes are safe? What's the level of confidence?

Thanks

@danielfleischer
Copy link
Author

danielfleischer commented Nov 23, 2020

I've used the Vector and AVector classes, but I'm not aware of any official verifications.

See vectorz and the clojure bindings vectorz-clj for more detail.

@ptaoussanis
Copy link
Member

ptaoussanis commented Nov 25, 2020

Hi there!

Unfortunately I don't think this'd make sense to add to the default list for a couple reasons:

  1. Someone would need to properly investigate to check that there's no security risk posed by any of the classes. This is a solvable problem but would take some work.
  2. I'm not sure that this library is common enough to warrant inclusion in the defaults.

Why does 2. matter?

  • Noise for library consumers. (If we add defaults for this long-tail library, we'd be setting a precedent for more such additions - making it more cumbersome for users to review+manage the whitelist).
  • Added default classes also impose an ongoing maintenance burden since we'll need to keep an eye out for possible security issues in new releases, etc.

Would recommend you just add the classes you need to your own configuration.

Hope this makes sense!

Cheers :-)

@danielfleischer
Copy link
Author

Hi, thanks for the clarification, it makes perfect sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants