Preserve invalid nested A tags in AST #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Atags which were nested are invalid HTML.Example
Browsers and some parsers (like parse5) handle this by correcting the HTML as follows:
This library did not fix these tags, until PR #148
New Behaviour
We have determined that the behaviour of fixing the nested A tag is not appropriate for this sort of parser. Parsers which apply fixes produce full compliant HTML, ready for browser consumption. That is not the purpose of this library.
Because this can be considered a breaking change, we are incrementing the major version #
To support legacy applications which rely on this behaviour being done quickly, during parse, we've silently introduced a new option, which is disabled by default:
fixNestedATags