Fix 144 #148
Merged
Fix 144 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taoqf Looks like you've got a bit going on that's keeping you busy. Would you be willing to make me a maintainer so I can help keep things moving and address some of the issues? For some background, I understand the priority of speed, and I maintain several large / critical repos. I'd be happy to help. Also, I have a month old ticket waiting on this — at the very least, can we merge this PR? |
|
@nonara Happy to hear this. |
|
Busy is not the only thing stop me, but also the gfw. I am not access to github for month. |
|
Thanks! Will be glad to help out. Sorry to hear about that. I didn't realize the GFW was blocking GitHub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Performance Notes
When I said it wouldn't have a perf impact, I should have more correctly stated that the impact would be negligible.
I did a bit of perf testing and found that the added operation:
if (myVar === 'a' || myVar === 'A')runs at 436,132,968 ops per second. The extra bit of logic inside the conditional will be even less impactful, as it will rarely execute, and is also extremely inexpensive.In short, I don't expect a noticeable difference for the changes.