Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: support vg id and fix code style #116

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

sunpe
Copy link
Contributor

@sunpe sunpe commented Dec 15, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #116 (a9ee9b8) into main (7aad046) will decrease coverage by 0.99%.
The diff coverage is 94.00%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   78.73%   77.73%   -1.00%     
==========================================
  Files          14       19       +5     
  Lines        1881     2183     +302     
==========================================
+ Hits         1481     1697     +216     
- Misses        400      486      +86     
Impacted Files Coverage Δ
taos/bind.py 80.14% <75.00%> (-0.05%) ⬇️
taos/connection.py 88.67% <80.00%> (ø)
taos/cinterface.py 73.23% <94.44%> (+0.29%) ⬆️
taos/__init__.py 100.00% <100.00%> (ø)
taos/cursor.py 74.68% <100.00%> (ø)
taos/error.py 97.82% <100.00%> (ø)
taos/field.py 81.01% <100.00%> (-0.12%) ⬇️
taos/field_v3.py 92.68% <100.00%> (ø)
taos/result.py 72.82% <100.00%> (+0.54%) ⬆️
taos/schemaless.py 100.00% <100.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunpe sunpe requested review from zitsen and sangshuduo December 16, 2022 02:33
Copy link
Contributor

@sangshuduo sangshuduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

taos/cinterface.py Outdated Show resolved Hide resolved
taos/cinterface.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sangshuduo sangshuduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangshuduo sangshuduo merged commit 287a892 into main Dec 19, 2022
@sunpe sunpe deleted the enh/sunpeng/TD-21276-support-get-vg-id branch December 20, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants