Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize path separators in stripFullStack #402

Merged
merged 1 commit into from
Oct 15, 2017

Conversation

nhamer
Copy link
Contributor

@nhamer nhamer commented Oct 14, 2017

unit tests fail on windows, because they expect e.g.:
at: Test. ($TEST\undef.js:$LINE:$COL)
but get
at: Test. ($TEST/undef.js:$LINE:$COL)

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great change!

@ljharb ljharb added the tests label Oct 15, 2017
@ljharb ljharb merged commit 13173a5 into tape-testing:master Oct 15, 2017
@nhamer nhamer deleted the stack_strip branch October 16, 2017 00:50
ljharb added a commit that referenced this pull request Feb 19, 2018
 - [New] use `process.env.NODE_TAPE_OBJECT_PRINT_DEPTH` for the default object print depth (#420)
 - [New] Add "onFailure" listener to test harness (#408)
 - [Fix] fix stack where actual is falsy (#400)
 - [Fix] normalize path separators in stacks (#402)
 - [Fix] fix line numbers in stack traces from inside anon functions (#387)
 - [Fix] Fix dirname in stack traces (#388)
 - [Robustness] Use local reference for clearTimeout global (#385)
 - [Deps] update `function-bind`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants