forked from fl00r/go-tarantool-1.6
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add pagination support #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c90bad
to
4f34aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Seems nice, I've found a couple of tricks that may be useful for me later. I have left a several minor comments.
4f34aaf
to
bb99816
Compare
A user could fetch a position of a last tuple using a new method of the SelectRequest type: selectRequest = selectRequest.FetchPos(true) The position will be stored in a new field of the Response type: Response.Pos A user could specify a tuple from which selection must continue or its position with a new method of the SelectRequest type: selectRequest = selectRequest.After([]interface{}{23}) or selectRequest = selectRequest.After(resp.Pos) In action it looks like: req := NewSelectRequest(space).Key(key).Limit(10).FetchPos(true) for condition { resp, err := conn.Do(req).Get() // ... req = req.After(resp.Pos) } 1. tarantool/tarantool#7639 Part of #246
bb99816
to
930d5a0
Compare
DifferentialOrange
approved these changes
Jan 12, 2023
AnaNek
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user could fetch a position of a last tuple using a new method of the SelectRequest type:
The position will be stored in a new field of the Response type:
A user could specify a tuple from which selection must continue or its position with a new method of the SelectRequest type:
or
In action it looks like:
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #246