Skip to content

Commit

Permalink
cleanup unused plasma properties
Browse files Browse the repository at this point in the history
  • Loading branch information
jvshields committed Jan 9, 2024
1 parent 3fc77d3 commit 993a877
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions stardis/plasma/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ def calculate(
atomic_data,
ion_number_density,
t_electrons,
g,
ionization_data,
partition_function,
):
Expand All @@ -164,6 +163,8 @@ def calculate(
# emission_correction = (1-e^(-h*nu / kT))
# alphas = ALPHA_COEFFICIENT * n_lower * f_lu * emission_correction

###TODO: handle other broadening parameters

points = len(t_electrons)

linelist = atomic_data.linelist.rename(columns={"ion_charge": "ion_number"})[
Expand Down Expand Up @@ -298,10 +299,10 @@ def calculate(
atomic_data,
ion_number_density,
t_electrons,
g,
ionization_data,
partition_function,
):
###TODO: handle other broadening parameters
points = len(t_electrons)

Check warning on line 306 in stardis/plasma/base.py

View check run for this annotation

Codecov / codecov/patch

stardis/plasma/base.py#L306

Added line #L306 was not covered by tests

linelist = atomic_data.linelist.rename(columns={"ion_charge": "ion_number"})[

Check warning on line 308 in stardis/plasma/base.py

View check run for this annotation

Codecov / codecov/patch

stardis/plasma/base.py#L308

Added line #L308 was not covered by tests
Expand Down Expand Up @@ -348,8 +349,6 @@ def calculate(
exponent_by_point * linelist_with_densities[np.arange(points)]
).values.T # arange mask of the dataframe returns the set of densities of the appropriate ion for the line at each point

linelist["gf"] = 10**linelist.log_gf

line_nus = (linelist.wavelength.values * u.AA).to(

Check warning on line 352 in stardis/plasma/base.py

View check run for this annotation

Codecov / codecov/patch

stardis/plasma/base.py#L352

Added line #L352 was not covered by tests
u.Hz, equivalencies=u.spectral()
)
Expand All @@ -369,7 +368,7 @@ def calculate(
(
ALPHA_COEFFICIENT
* prefactor
* linelist.gf.values
* 10**linelist.log_gf.values
* emission_correction.T
).T
)
Expand Down

0 comments on commit 993a877

Please sign in to comment.