Donot run docs, benchmarks and stardis tests on draft PRs. #2761

KasukabeDefenceForce · 2024-07-30T05:36:41Z

📝 Description

This PR makes sure that the build docs, benchmarks and stardis tests are run on a PR which is ready for review.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot · 2024-07-30T05:37:05Z

*beep* *bop*
Hi human,
I ran ruff on the latest commit (4b63c66).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

codecov · 2024-07-30T05:52:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (7231707) to head (4b63c66).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   69.86%   69.30%   -0.56%     
==========================================
  Files         192      192              
  Lines       15048    15048              
==========================================
- Hits        10513    10429      -84     
- Misses       4535     4619      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KasukabeDefenceForce · 2024-07-30T13:40:23Z

Sample PR to test the changes:
KasukabeDefenceForce#39

Sample Run:
KasukabeDefenceForce#38

andrewfullard · 2024-07-30T13:44:16Z

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

KasukabeDefenceForce · 2024-07-30T13:47:16Z

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

andrewfullard · 2024-07-30T13:52:19Z

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

I can't mark the PR as ready for review on your fork but I do see the actions running.

KasukabeDefenceForce · 2024-07-30T13:55:32Z

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

I can't mark the PR as ready for review on your fork but I do see the actions running.

Oh I forgot about that, apologies. Yes, it is setup in a way that the tests will start after we shift it to ready for review.

* added setup function Signed-off-by: Asish Kumar <[email protected]> * refactor geometry calculate distances Signed-off-by: Asish Kumar <[email protected]> * Refactor montecarlo estimators in benchmark code Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * add cache and setup functions Signed-off-by: Asish Kumar <[email protected]> * ran ruff linter Signed-off-by: Asish Kumar <[email protected]> * Thou hath vanquished the redundant variables and functions Signed-off-by: Asish Kumar <[email protected]> * fix bugs Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> * repeat in class Signed-off-by: Asish Kumar <[email protected]> * Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720) * Benchmark run_tardis with track_rpacket enabled * Update config to resemble time_run_tardis config * Fix Benchmark error * Cache Benchmark Property * Remove Cached Property decorator * rounds in benchmarks Signed-off-by: Asish Kumar <[email protected]> * fix Signed-off-by: Asish Kumar <[email protected]> * fix error in formal integral Signed-off-by: Asish Kumar <[email protected]> * more cache Signed-off-by: Asish Kumar <[email protected]> * sort by ratio Signed-off-by: Asish Kumar <[email protected]> * Donot run docs, benchmarks and stardis tests on draft PRs. (tardis-sn#2761) * Add ready to review to run tests * Add if condition to check PR status * Running stardis tests only on push to master * Removing osx-64 from workflows * Add Extend Array Function (tardis-sn#2771) * Add Extend Array Function * Fix Typo and restructure * Restructure * Doc string update * Was expecting numpy arrays to be passed by reference but it is not so updating it * Add test for the extend array function * Opacity state slice (tardis-sn#2758) * Added basic sliing operation to opacitystate and set the transport solver to use the bounds of the gemoetry indices * Reformatted the slicing index * Added slicing operation with __getitem__ * Added docstring * removed old slice method * Ran black * Added back the 'slice' method because __getitem__ is wacky * added missing argument * fixed missing argument * ran black * fixed the tests * ran black * Updated the slice to use __getitem__ again and modified the opacitystate object defined in the opacities module * Removed old slice method and print statements * removed print statement from the test * added type annotation to OpacityState getitem * updated numba interface * Fixes black formatting * Release Pipeline Fixes (tardis-sn#2767) * Fix zenodo badge * Pick from the website * update badge in credits.rst * Use the all versions DOI * Inherit secrets * Change triggers for testing * Reset Triggers * Fix ruff comments issue (tardis-sn#2762) * Fix ruff comments issue * Only check files changed * Testing triggers * Fix bash commands * No pager * fetch depth * Reset all changes * cache in setup function Signed-off-by: Asish Kumar <[email protected]> * change benchmark yml Signed-off-by: Asish Kumar <[email protected]> --------- Signed-off-by: Asish Kumar <[email protected]> Co-authored-by: Sumit Gupta <[email protected]> Co-authored-by: KasukabeDefenceForce <[email protected]> Co-authored-by: Jack O'Brien <[email protected]> Co-authored-by: Andrew Fullard <[email protected]> Co-authored-by: Atharva Arya <[email protected]>

KasukabeDefenceForce added 3 commits July 30, 2024 11:08

Add ready to review to run tests

c4b0ea0

Add if condition to check PR status

b110f0e

Running stardis tests only on push to master

b5565cd

KasukabeDefenceForce force-pushed the draft_rtr branch from a3ee609 to b5565cd Compare July 30, 2024 05:39

atharva-2001 added the infrastructure label Jul 30, 2024

Removing osx-64 from workflows

4b63c66

KasukabeDefenceForce requested a review from andrewfullard July 30, 2024 12:59

KasukabeDefenceForce requested a review from atharva-2001 July 30, 2024 13:40

KasukabeDefenceForce marked this pull request as ready for review July 30, 2024 13:41

andrewfullard approved these changes Jul 30, 2024

View reviewed changes

atharva-2001 approved these changes Aug 1, 2024

View reviewed changes

atharva-2001 merged commit 642e191 into tardis-sn:master Aug 1, 2024
17 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Donot run docs, benchmarks and stardis tests on draft PRs. #2761

Donot run docs, benchmarks and stardis tests on draft PRs. #2761

KasukabeDefenceForce commented Jul 30, 2024

tardis-bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

KasukabeDefenceForce commented Jul 30, 2024 •

edited

Loading

andrewfullard commented Jul 30, 2024

KasukabeDefenceForce commented Jul 30, 2024

andrewfullard commented Jul 30, 2024

KasukabeDefenceForce commented Jul 30, 2024

Donot run docs, benchmarks and stardis tests on draft PRs. #2761

Donot run docs, benchmarks and stardis tests on draft PRs. #2761

Conversation

KasukabeDefenceForce commented Jul 30, 2024

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

tardis-bot commented Jul 30, 2024 • edited Loading

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

KasukabeDefenceForce commented Jul 30, 2024 • edited Loading

andrewfullard commented Jul 30, 2024

KasukabeDefenceForce commented Jul 30, 2024

andrewfullard commented Jul 30, 2024

KasukabeDefenceForce commented Jul 30, 2024

tardis-bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

KasukabeDefenceForce commented Jul 30, 2024 •

edited

Loading