Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the codespell job failures #2919

Closed
wants to merge 1 commit into from
Closed

Conversation

Sonu0305
Copy link
Contributor

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Fixes the issue(#2903)

📌 Resources

Stack Overflow

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (ae6a8e8).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

1	E701	[ ] Multiple statements on one line (colon)
1	E999	[ ] SyntaxError: Expected an expression
1	W292	[*] No newline at end of file
1	W293	[*] Blank line contains whitespace

Complete output(might be large):

.github/workflows/codespell.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/codespell.yml:22:11: E701 Multiple statements on one line (colon)
.github/workflows/codespell.yml:35:1: W293 [*] Blank line contains whitespace
.github/workflows/codespell.yml:38:99: W292 [*] No newline at end of file
Found 4 errors.
[*] 2 fixable with the `--fix` option.

@Sonu0305 Sonu0305 closed this Dec 31, 2024
@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (e24ccce) and the latest commit (ae6a8e8).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

| Change   | Before [e24cccec] <master>   | After [ae6a8e88]    |   Ratio | Benchmark (Parameter)                                                                                   |
|----------|------------------------------|---------------------|---------|---------------------------------------------------------------------------------------------------------|
| +        | 1.73±0.02ms                  | 2.00±0.01ms         |    1.16 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [e24cccec] <master>   | After [ae6a8e88]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 42.1±30μs                    | 57.4±30μs           | ~1.36   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |
|          | 3.03±0.7μs                   | 3.60±0.3μs          | ~1.19   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 1.42±0.3μs                   | 1.68±0.3μs          | ~1.18   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 21.8±5μs                     | 25.0±6μs            | ~1.15   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 2.10±2μs                     | 2.40±2μs            | ~1.14   | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 8.51±8μs                     | 7.39±2μs            | ~0.87   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 621±100ns                    | 531±100ns           | ~0.86   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 67.9±30μs                    | 43.3±40μs           | ~0.64   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 6.42±1μs                     | 3.29±0.4μs          | ~0.51   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 64.7±0.09ms                  | 69.7±2ms            | 1.08    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 2.76±0.4ms                   | 2.96±0.5ms          | 1.07    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 39.1±0.04μs                  | 40.5±0.02μs         | 1.03    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 561±100ns                    | 571±200ns           | 1.02    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 3.18±0.03ms                  | 3.21±0ms            | 1.01    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 531±100ns                    | 531±100ns           | 1.00    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 1.05±0m                      | 1.05±0m             | 1.00    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 2.08±0m                      | 2.08±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 39.6±0.1s                    | 39.1±0.04s          | 0.99    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 1.22±0μs                     | 1.19±0μs            | 0.98    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 209±0.1ns                    | 203±0.2ns           | 0.97    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 751±0.3ns                    | 718±0.4ns           | 0.96    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 4.32±0.02ms                  | 4.09±0.03ms         | 0.95    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 7.47±1μs                     | 6.89±0.6μs          | 0.92    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |

Benchmarks that have got worse:

| Change   | Before [e24cccec] <master>   | After [ae6a8e88]    |   Ratio | Benchmark (Parameter)                                                                                   |
|----------|------------------------------|---------------------|---------|---------------------------------------------------------------------------------------------------------|
| +        | 1.73±0.02ms                  | 2.00±0.01ms         |    1.16 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |

If you want to see the graph of the results, you can check it here

@Sonu0305 Sonu0305 deleted the fix#2903 branch January 1, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants