Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed data download link mentioned under Quickstart for TARDIS #2922

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Sonu0305
Copy link
Contributor

@Sonu0305 Sonu0305 commented Jan 4, 2025

📝 Description

Type: 🪲 bugfix | 📝 documentation

Replaced the corrupted link with the working link.
Fixes #2768

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 4, 2025

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 4, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (598d331).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

2	W291	[*] Trailing whitespace
2	W605	[*] Invalid escape sequence: `\A`
1	E999	[ ] SyntaxError: Expected an expression
1	W292	[*] No newline at end of file

Complete output(might be large):

.mailmap:1:38: E999 SyntaxError: Expected an expression
.mailmap:292:39: W292 [*] No newline at end of file
docs/quickstart.ipynb:cell 12:1:39: W291 [*] Trailing whitespace
docs/quickstart.ipynb:cell 12:5:35: W291 [*] Trailing whitespace
docs/quickstart.ipynb:cell 16:10:26: W605 [*] Invalid escape sequence: `\A`
docs/quickstart.ipynb:cell 16:11:40: W605 [*] Invalid escape sequence: `\A`
Found 6 errors.
[*] 5 fixable with the `--fix` option.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 4, 2025

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (7e37d5f) and the latest commit (598d331).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [7e37d5fe] <master>   | After [598d3319]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 7.39±1μs                     | 8.95±2μs            | ~1.21   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 20.4±4μs                     | 24.5±6μs            | ~1.20   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 3.25±0.2μs                   | 3.87±1μs            | ~1.19   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 1.39±0.4μs                   | 1.53±0.7μs          | ~1.10   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 3.10±0.6μs                   | 3.42±0.9μs          | ~1.10   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 561±200ns                    | 461±200ns           | ~0.82   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 68.6±10μs                    | 41.5±20μs           | ~0.60   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |
|          | 2.10±2μs                     | 2.30±2μs            | 1.10    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 3.78±0.03ms                  | 3.96±0.08ms         | 1.05    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 2.59±0.5ms                   | 2.70±0.4ms          | 1.04    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 2.62±0ms                     | 2.65±0.01ms         | 1.01    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 1.66±0.02ms                  | 1.68±0.01ms         | 1.01    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 1.04±0m                      | 1.04±0m             | 1.00    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 2.08±0m                      | 2.08±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 205±0.1ns                    | 204±0.1ns           | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 38.6±0.05s                   | 38.2±0.01s          | 0.99    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 717±0.09ns                   | 708±0.5ns           | 0.99    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 6.38±1μs                     | 6.33±0.8μs          | 0.99    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |
|          | 631±200ns                    | 621±200ns           | 0.98    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 591±100ns                    | 571±200ns           | 0.97    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 46.0±30μs                    | 44.7±20μs           | 0.97    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 64.0±0.3ms                   | 61.8±0.2ms          | 0.97    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 40.1±0.03μs                  | 38.0±0.02μs         | 0.95    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 1.26±0μs                     | 1.19±0μs            | 0.94    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |

If you want to see the graph of the results, you can check it here

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Jan 4, 2025

Hi @wkerzendorf @Knights-Templars @atharva-2001 @andrewfullard @epassaro ,
Could one of you please review this when you get a chance?
Thank You for Your Time and Support.

@andrewfullard
Copy link
Contributor

tardis-refdata is deprecated. Please use https://github.com/tardis-sn/tardis-regression-data instead.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Jan 6, 2025

tardis-refdata is deprecated. Please use https://github.com/tardis-sn/tardis-regression-data instead.

@andrewfullard
Done, Thanks. Please review it when you have a chance.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Jan 7, 2025

Also @andrewfullard ,
To ensure that there are no merge conflicts when #2908 is merged, I reverted the changes (excluded the changes of codespell failure over here) to ensure clean merging.
Sorry for any inconvenience, will take care of it next time.
Please review the changes when you have a chance, Thank You.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Jan 9, 2025

Hi @jvshields @atharva-2001 ,
Please review this when you have a chance, Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart link for downloading the kurucz_cd23_chianti_H_He.h5 dataset is faulty
3 participants