-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opacity_state_to_numba -> to_numba and moved to as a method of class OpacityState #2932
base: master
Are you sure you want to change the base?
Conversation
*beep* *bop* 2 RET505 [ ] Unnecessary `else` after `return` statement
1 ANN204 [ ] Missing return type annotation for special method `__getitem__`
1 INP001 [ ] File `tardis/opacities/tests/test_opacity_state_numba.py` is part of an implicit namespace package. Add an `__init__.py`.
1 RET506 [ ] Unnecessary `else` after `raise` statement
1 I001 [*] Import block is un-sorted or un-formatted
1 D202 [*] No blank lines allowed after function docstring (found 1)
1 D406 [*] Section name should end with a newline ("Returns")
1 D407 [*] Missing dashed underline after section ("Returns")
1 F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
1 F821 [ ] Undefined name `opacity_state_numba`
Complete output(might be large): tardis/opacities/opacity_state.py:110:9: ANN204 Missing return type annotation for special method `__getitem__`
tardis/opacities/opacity_state.py:116:9: D407 [*] Missing dashed underline after section ("Returns")
tardis/opacities/opacity_state.py:116:9: D406 [*] Section name should end with a newline ("Returns")
tardis/opacities/opacity_state.py:247:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/opacities/tests/test_opacity_state_numba.py:1:1: INP001 File `tardis/opacities/tests/test_opacity_state_numba.py` is part of an implicit namespace package. Add an `__init__.py`.
tardis/opacities/tests/test_opacity_state_numba.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/opacities/tests/test_opacity_state_numba.py:2:44: F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
tardis/spectrum/formal_integral.py:369:13: RET506 Unnecessary `else` after `raise` statement
tardis/spectrum/formal_integral.py:709:5: RET505 Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral.py:745:5: RET505 Unnecessary `else` after `return` statement
tardis/transport/montecarlo/base.py:133:31: F821 Undefined name `opacity_state_numba`
Found 11 errors.
[*] 5 fixable with the `--fix` option.
|
Hi @andrewfullard @atharva-2001 , |
Tests pass in master, that means it has something to with this PR right? |
Okay Thank You, I will look into it soon. |
📝 Description
Type: 🎢
infrastructure
opacity_state_to_numba
->to_numba
OpacityState
Closes #2882
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label