-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port): allow custom listener port #132
Merged
wass3r
merged 6 commits into
target:master
from
dpritchett:djp-parameterize-slack-listener-port
Apr 5, 2020
Merged
feat(port): allow custom listener port #132
wass3r
merged 6 commits into
target:master
from
dpritchett:djp-parameterize-slack-listener-port
Apr 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpritchett
requested review from
JordanSussman,
pa3ng,
sjqnn and
wass3r
as code owners
March 12, 2020 22:52
Having a few glitches with the test suite locally due to not running in Linux the way travis does and a checksum problem with the slack plugin. Please standby and I'll sort it. |
Pull Request Test Coverage Report for Build 742029b3a076c9caa1261bd3b07b42791ef5f3d0-PR-132
💛 - Coveralls |
wass3r
reviewed
Mar 13, 2020
thank you for the contribution. looks good to me. just working on fixing our pipeline and this will get in. thanks for the patience. |
wass3r
changed the title
POC of parameterized slack event listener port
feat(port): allow custom listener port
Apr 5, 2020
wass3r
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤ THANKS FOR HELPING OUT :D
Proposed change
Add a
slack_listener_port
config parser to allow for overriding the default port of3000
for the slack events listener.Why? Heroku's docker-based setup insists on being able to inject a
PORT
variable, probably so their backend load balancers can more easily pack 'em in.Types of changes
What types of changes is this pull request introducing to flottbot? Put an
x
in the boxes that applyChecklist
You can fill this out after creating your PR. Put an
x
in the boxes that applyI plan to show this in #flottbot slack and see if there's a good place to slide in some more relevant docs.