Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port): allow custom listener port #132

Merged

Conversation

dpritchett
Copy link
Contributor

❤ THANKS FOR HELPING OUT :D

Proposed change

Add a slack_listener_port config parser to allow for overriding the default port of 3000 for the slack events listener.

Why? Heroku's docker-based setup insists on being able to inject a PORT variable, probably so their backend load balancers can more easily pack 'em in.

image

image

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

I plan to show this in #flottbot slack and see if there's a good place to slide in some more relevant docs.

@dpritchett
Copy link
Contributor Author

Having a few glitches with the test suite locally due to not running in Linux the way travis does and a checksum problem with the slack plugin. Please standby and I'll sort it.

@coveralls
Copy link

coveralls commented Mar 12, 2020

Pull Request Test Coverage Report for Build 742029b3a076c9caa1261bd3b07b42791ef5f3d0-PR-132

  • 63 of 68 (92.65%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 42.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/outputs.go 0 1 0.0%
remote/slack/helper.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
remote/remote.go 2 0%
Totals Coverage Status
Change from base Build 0a738920d2087b9c0faa45fc96b9efe413fe883d: 0.4%
Covered Lines: 788
Relevant Lines: 1845

💛 - Coveralls

core/configure_test.go Outdated Show resolved Hide resolved
@wass3r
Copy link
Collaborator

wass3r commented Mar 19, 2020

thank you for the contribution. looks good to me. just working on fixing our pipeline and this will get in. thanks for the patience.

@wass3r wass3r added the enhancement New feature or request label Apr 5, 2020
@wass3r wass3r changed the title POC of parameterized slack event listener port feat(port): allow custom listener port Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants