You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What problem would you like to solve? Please describe:
The current remote monitor module lacks optimized functionalities such as JSON logging, a dedicated endpoint for Twilio calls and a mechanism to trace messages back to their source.
Describe the solution you'd like:
Implement JSON logging for the remote monitor, ensuring alignment with the rest of the application.
Create a specific endpoint for Twilio calls to avoid 'Missing X-Twilio-Signature' errors. This will also reduce confusion by separating expected Twilio traffic from other requests.
Log the message SIDs for better traceability. This will allow us to trace messages through logs elsewhere, facilitating easier troubleshooting and monitoring.
Describe alternatives you've considered:
Currently, it's possible to conduct a track-back of issues to Twilio using time estimates and educated guesses, or running tcpdump on the pod. However, these methods are inefficient and imprecise.
Additional context:
The proposed features will enhance the user experience for remote monitor by providing better logging, error reduction, and traceability of messages.
The text was updated successfully, but these errors were encountered:
Create a specific endpoint for Twilio calls to avoid 'Missing X-Twilio-Signature' errors. This will also reduce confusion by separating expected Twilio traffic from other requests.
for #2 request, upon checking the code, the error originates from a validation function and it seems like this validation is only related to Twilio requests based on the error messages it's throwing. So I would like to ask if this validation should only be applied to Twilio requests and exclude all other requests from it, that way unrelated requests would not throw this Twilio error, is that right?
Checking the code app/inithttp.go, starting from line 190, the validation only filters for Twilio requests so I think there's no need for #2. Just need someone to double check it.
For #3, the implemented logging (util/log/log.go) already integrates the RequestID in all log levels. I just don't know if RequestID is same as the SIDs...
1ddo
pushed a commit
to 1ddo/goalert
that referenced
this issue
Aug 2, 2023
What problem would you like to solve? Please describe:
The current remote monitor module lacks optimized functionalities such as JSON logging, a dedicated endpoint for Twilio calls and a mechanism to trace messages back to their source.
Describe the solution you'd like:
Describe alternatives you've considered:
Currently, it's possible to conduct a track-back of issues to Twilio using time estimates and educated guesses, or running
tcpdump
on the pod. However, these methods are inefficient and imprecise.Additional context:
The proposed features will enhance the user experience for remote monitor by providing better logging, error reduction, and traceability of messages.
The text was updated successfully, but these errors were encountered: