ui/schedules: temp sched calendar override button #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Working on some changes right now. I thought I ran the cypress tests before making original PR but didn't 😮 . |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Nathaniel Caza <[email protected]>
KatieMSB
requested changes
Aug 26, 2021
dctalbot
suggested changes
Sep 1, 2021
dctalbot
suggested changes
Sep 3, 2021
There was a problem hiding this comment.
Nice progress! One more thing we need to do is disable to "replaced user" field when doing a replace/remove override. Left some suggestions for how we could achieve that.
Also, if you're interested in converting some of the new files into typescript, that could be great for keeping our component props interfaces clean and minimal.
web/src/app/schedules/calendar/ScheduleCalendarOverrideDialog.js
Outdated
Show resolved
Hide resolved
Co-authored-by: David Talbot <[email protected]>
…ality to handle edge cases
dctalbot
suggested changes
Sep 8, 2021
Co-authored-by: David Talbot <[email protected]>
dctalbot
previously approved these changes
Sep 8, 2021
dctalbot
previously approved these changes
Sep 8, 2021
dctalbot
approved these changes
Sep 9, 2021
pnengchu
approved these changes
Sep 9, 2021
KatieMSB
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR modified the schedule calendar functionality (see pictures) so that it's more clear what changes do. It replaced the temporary schedule button on the upper right of the calendar with an override button. It also replaces the "remove" and "replace" buttons when you click on a shift with a general "override shift" button.
Both these override buttons bring you to a dialog where you can choose the type of override you want to do (including a temp schedule).
Which issue(s) this PR fixes:
Usage:
Fixes #<issue number>, orFixes (paste link of issue).Out of Scope:
Include any out of scope items here.
Screenshots:
If applicable, add some screenshots here.
New schedule buttons (override and override shift buttons):
After clicking "override shift":
After clicking "override":
Describe any introduced user-facing changes:
Describe any introduced API changes:
If introducing any API changes, provide a clear description of them.
Additional Info:
Any additional information or context.