-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/schedules: Temp sched no coverage on page checkbox #1891
Merged
spencerpauly
merged 16 commits into
master
from
temp-sched-no-coverage-on-page-checkbox
Sep 21, 2021
Merged
ui/schedules: Temp sched no coverage on page checkbox #1891
spencerpauly
merged 16 commits into
master
from
temp-sched-no-coverage-on-page-checkbox
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dctalbot
suggested changes
Sep 8, 2021
Co-authored-by: David Talbot <[email protected]>
Co-authored-by: David Talbot <[email protected]>
dctalbot
previously approved these changes
Sep 9, 2021
Forfold
requested changes
Sep 13, 2021
Forfold
previously approved these changes
Sep 20, 2021
dctalbot
suggested changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not catching it the first time, but we need to handle the loading state of the time zone from useScheduleTZ
Co-authored-by: David Talbot <[email protected]>
Co-authored-by: David Talbot <[email protected]>
dctalbot
approved these changes
Sep 21, 2021
Forfold
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
Please include a description of the proposed changes.
This should include details if the user experience is impacted.
Which issue(s) this PR fixes:
This is a different solution from the one in this draft PR: #1870
Out of Scope:
Screenshots:
Describe any introduced user-facing changes:
User now must select "allow no coverage" checkbox if they'd like to be able to create a temp schedule with coverage gaps in it.
Describe any introduced API changes:
If introducing any API changes, provide a clear description of them.
Additional Info:
Any additional information or context.
Previous solution done in this draft PR: #1870