Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/schedules: Temp sched no coverage on page checkbox #1891

Merged
merged 16 commits into from
Sep 21, 2021

Conversation

spencerpauly
Copy link
Contributor

@spencerpauly spencerpauly commented Sep 8, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Please include a description of the proposed changes.
This should include details if the user experience is impacted.

Which issue(s) this PR fixes:
This is a different solution from the one in this draft PR: #1870

Out of Scope:

Screenshots:

Screen Shot 2021-09-08 at 11 31 02 AM

Describe any introduced user-facing changes:
User now must select "allow no coverage" checkbox if they'd like to be able to create a temp schedule with coverage gaps in it.

Describe any introduced API changes:
If introducing any API changes, provide a clear description of them.

Additional Info:
Any additional information or context.
Previous solution done in this draft PR: #1870

@spencerpauly spencerpauly changed the title Temp sched no coverage on page checkbox ui/schedules: Temp sched no coverage on page checkbox Sep 8, 2021
dctalbot
dctalbot previously approved these changes Sep 9, 2021
Forfold
Forfold previously approved these changes Sep 20, 2021
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not catching it the first time, but we need to handle the loading state of the time zone from useScheduleTZ

@spencerpauly spencerpauly merged commit 7d576bb into master Sep 21, 2021
@spencerpauly spencerpauly deleted the temp-sched-no-coverage-on-page-checkbox branch September 21, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants