-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notification/slack: update existing messages with status #2004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a personal preference, I think it could look a bit cleaner without the nested quote line for the details- LGTM!
@Forfold Maybe we can try tweaking it during the two-way interaction work; we'll be changing the rendering logic for that into its final state. I added it so it would stand out since there's no pre-processing for markdown -> slack markdown, but I agree the double color-bar isn't ideal. |
@mastercactapus That sounds good! Yeah I definitely don't think something like that should hold us back, so it has my approval :) |
It could be neat to have a button to show the full details (rendered with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
This PR updates the Slack notifier to include a color bar with alert messages and update the existing message instead of posting status updates in-thread.
Unacked alerts will have a red bar and details included:

Acked alerts will reflect the latest log entry, a yellow bar, and retain details:

When escalated, the alert summary and link is broadcast to the channel:

When closed, details of the alert is hidden, bar turns green, and the link remains with the last log entry:
