Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification/slack: add interactivity to alert notifications #2014

Merged
merged 19 commits into from
Nov 9, 2021

Conversation

mastercactapus
Copy link
Member

Description:
Adds two-way interactivity as an option for Slack notifications.

Additional Info:
Summary of changes:

  • make alert log store support both contact methods and notification channels for ack/close actions
  • new http route /api/v2/slack/message-action added
  • new config option Slack.InteractiveMessages to opt-in
  • action support in the mockslack server
  • new ReceiveSubject method that can map a provider/subject ID to a GoAlert user for notification channel responses
  • remove alert as a dependency for the notification package by using a new AlertState type instead of alert.Status
  • updated Send() method in Slack ChannelSender to add action blocks
  • added support for Ephemeral messages and actions and assertions in test harness/mockslack
  • added slack interaction smoketest
  • added FindOneBySubject to user.Store
  • added FieldErrorf to validation package to support formatting error messages cleaner

@mastercactapus mastercactapus marked this pull request as ready for review November 9, 2021 14:58
@arurao arurao self-requested a review November 9, 2021 16:07
Copy link
Contributor

@arurao arurao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mastercactapus mastercactapus merged commit fe6ac46 into master Nov 9, 2021
@mastercactapus mastercactapus deleted the slack-two-way branch November 9, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants