engine/metricsmanager: add daily_alert_metrics
table
#2272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR adds a new
daily_alert_metrics
table that aggregates metrics fromalert_metrics
. We do this basically as a cacheing strategy for the metrics API targets.How to test:
make regendb
make start
engine_processing_versions.state
update wheretype_id = 'metrics'
LastMetricsDate
will never exceed the date ofLastLogTime
. Therefore, to get metrics for the current day, one must look inalert_metrics
.alert_metrics
anddaily_alert_metrics
over time.Which issue(s) this PR fixes:
Closes #2122
Additional Information:
This PR modifies the local dev alert generation to be spread across the previous 30 days as opposed to 2 hours. This makes testing more interesting and realistic.