Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: poll all service's alerts within date range #2445

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 9, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR updates AlertMetric's query so that we continuously make requests until all alerts are received and saved for a service within the specified date range.

Which issue(s) this PR fixes:
#2436

@tony-tvu
Copy link
Collaborator Author

tony-tvu commented Jun 9, 2022

Closing due to work in progress

@tony-tvu tony-tvu closed this Jun 9, 2022
@tony-tvu tony-tvu reopened this Jun 10, 2022
@Forfold Forfold added this to the Alert Metrics MVP+1 milestone Jun 13, 2022
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@tony-tvu tony-tvu merged commit f5beb25 into master Jun 13, 2022
@tony-tvu tony-tvu deleted the query-all-rows-AlertMetrics branch June 13, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants