Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert metrics: use alerts query for graph data #2448

Merged
merged 7 commits into from
Jun 15, 2022
Merged

Conversation

mastercactapus
Copy link
Member

Description:
This PR removes the use of the alertMetrics query in favor of making the alerts query the source-of-truth. Additionally, closedAt is added to the table and CSV export.

Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphs, tables, and CSV exports all working as expected on my end 👍

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! functionally tested as well 👍

@Forfold Forfold merged commit 6fbef47 into master Jun 15, 2022
@Forfold Forfold deleted the calc-graph-from-alerts branch June 15, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants