Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: add integration key filter for services list #2587

Merged
merged 19 commits into from
Sep 28, 2022

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds a new filter option for integration keys on the services list page.

Which issue(s) this PR fixes:
Fixes #2545

Screenshots:
Screen Shot 2022-08-23 at 11 09 19 AM

Describe any introduced API changes:
Adds new search query for integration keys and updates existing services search to include new filter option.

type IntegrationKeyConnection {
  nodes: [IntegrationKey!]!
  pageInfo: PageInfo!
}

input IntegrationKeySearchOptions {
  first: Int = 15
  after: String = ""
  search: String = ""
  omit: [String!]
}

# Allows searching for integration keys.
integrationKeys(input: IntegrationKeySearchOptions): IntegrationKeyConnection!

Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also thanks for converting JS files to TS 😃

@m17ch m17ch self-requested a review September 28, 2022 15:38
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KatieMSB KatieMSB merged commit 2ea20ad into master Sep 28, 2022
@KatieMSB KatieMSB deleted the integration-key-search branch September 28, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services: search by integration key
3 participants