-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: add pagination to message logs query #2644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
commented
Nov 1, 2022
mastercactapus
previously approved these changes
Nov 1, 2022
mastercactapus
previously approved these changes
Nov 1, 2022
mastercactapus
previously approved these changes
Nov 2, 2022
KatieMSB
requested changes
Nov 2, 2022
Co-authored-by: Katie Sydlik-Badgerow <[email protected]>
KatieMSB
approved these changes
Nov 2, 2022
mastercactapus
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
MessageLogs
to the schema for use. Searching by direct value is supported.DebugMessages
has been deprecated in favor of theMessageLog
terminology.PaginatedList
instead of using its own design pattern.There's some work that could be cleaned up around fetching the slack destination. It's kind of sloppy right now while I think of a better solution- open to suggestions.
Screenshots:
Out of Scope: