Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: add pagination to message logs query #2644

Merged
merged 41 commits into from
Nov 2, 2022
Merged

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Oct 3, 2022

Fixes #2600

  • Adds a paginated query MessageLogs to the schema for use. Searching by direct value is supported.
  • DebugMessages has been deprecated in favor of the MessageLog terminology.
  • Pagination follows patterns of other pages (e.g. Rotations) for consistency.
  • The list of logs as cards has been updated to use PaginatedList instead of using its own design pattern.

There's some work that could be cleaned up around fetching the slack destination. It's kind of sloppy right now while I think of a better solution- open to suggestions.

Screenshots:

Screen Shot 2022-10-04 at 2 43 44 PM

Screen Shot 2022-10-04 at 2 38 54 PM

Out of Scope:

  • Extending search options

@Forfold Forfold marked this pull request as ready for review October 4, 2022 21:42
mastercactapus
mastercactapus previously approved these changes Nov 1, 2022
mastercactapus
mastercactapus previously approved these changes Nov 1, 2022
mastercactapus
mastercactapus previously approved these changes Nov 2, 2022
Co-authored-by: Katie Sydlik-Badgerow <[email protected]>
@Forfold Forfold merged commit f5f5313 into master Nov 2, 2022
@Forfold Forfold deleted the msg-logs-paginate branch November 2, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message logs: access denied, auth limit
4 participants