Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-dm: add compat module #2821

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Feb 27, 2023

Description:
This PR adds a new engine module compat for performing eventual-consistency operations in the DB.

If the slack-dm flag is set, it will create new contact methods for slack entries in auth_subjects and create auth_subject entires for new slack DM contact methods.

Which issue(s) this PR fixes:
part of #2712

Additional Context:

  • for reviewing ensure make start EXPERIMENTAL=slack-dm is set
  • creating a Slack DM contact method should create an entry in the auth_subjects table
  • entries in the auth_subjects table for slack, should auto-generate matching contact methods

Copy link
Contributor

@cmarquis cmarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and verified as functional locally

@mastercactapus mastercactapus merged commit c305341 into master Mar 2, 2023
@mastercactapus mastercactapus deleted the feat/slack-dm-compat-mgr branch March 2, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants