feat: add UI for chanWebhooks escalation policy step option #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarquis
previously approved these changes
Mar 16, 2023
mastercactapus
requested changes
Mar 20, 2023
cmarquis
previously approved these changes
Mar 20, 2023
Co-authored-by: Nathaniel Caza <[email protected]>
Co-authored-by: Nathaniel Caza <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mastercactapus
approved these changes
Mar 20, 2023
cmarquis
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR adds UI support for adding chanWebhooks (webhook notification channels) to escalation policy steps.
Which issue(s) this PR fixes:
Part of #2691
This is a follow-up to #2809
Additional Info:
When the escalation policy step create dialog is opened for the first time, a bad
setState()call warning is rendered. This is from the feature flag updating, so it won't be relevant once this PR is approved and the feature flag is removed.Screenshots:
