Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: fix DM display and pending state #2890

Merged
merged 2 commits into from
Mar 23, 2023
Merged

slack: fix DM display and pending state #2890

merged 2 commits into from
Mar 23, 2023

Conversation

mastercactapus
Copy link
Member

Description:
This PR fixes 2 issues with the slack-dm feature

  • On the profile page, we should be using Profile.DisplayName instead of Name
  • Contact methods created from the compat module should have pending set to FALSE as they are considered verified through the linking process.

@mastercactapus mastercactapus merged commit cf0bd28 into master Mar 23, 2023
@mastercactapus mastercactapus deleted the slack-dm-pending-fix branch March 23, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @Forfold @KatieMSB