Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: preflight changes for message logs graph #3026

Merged
merged 10 commits into from
May 17, 2023
Merged

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented May 16, 2023

Part of #2460
Pre-flight PR to #2481

  • Renames AdminDebugMessagesLayout to AdminMessageLogsLayout
  • Renames DebugMessagesControls to AdminMessageLogsControls
  • Renames DebugMessageDetails to AdminMessageLogDrawer
  • Removes unused useFuse hook
  • Extends ListItem for the FlatListItem interface (the props are spread onto a ListItem element)
  • Updates PaginatedList to rely on items.length for no results, instead of pageCount
  • Updates PaginatedList to use a div for the secondary typography element, if the children is anything other than a string (helps with console warnings, DOM shouldn't be affected visually)
  • Adds title casing to both the type and ID for the ToolbarPageTitle component
  • Updates AlertAveragesGraph to use the sx prop for css instead of classes via makeStyles
  • Updates ISOPickers to update the input value if the incoming value changes
  • Updates ISOPickers coloring UX (fixes icon color in dark mode)

@target target deleted a comment from github-actions bot May 16, 2023
@target target deleted a comment from github-actions bot May 16, 2023
@target target deleted a comment from github-actions bot May 16, 2023
@target target deleted a comment from github-actions bot May 16, 2023
@target target deleted a comment from github-actions bot May 16, 2023
@target target deleted a comment from github-actions bot May 16, 2023
mastercactapus
mastercactapus previously approved these changes May 16, 2023
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, functionally validated

@Forfold Forfold merged commit b76d9d2 into master May 17, 2023
@Forfold Forfold deleted the preflight-graph-changes branch May 17, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants