-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: preflight changes for message logs graph #3026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
previously approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, functionally validated
mastercactapus
approved these changes
May 17, 2023
tony-tvu
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2460
Pre-flight PR to #2481
AdminDebugMessagesLayout
toAdminMessageLogsLayout
DebugMessagesControls
toAdminMessageLogsControls
DebugMessageDetails
toAdminMessageLogDrawer
useFuse
hookListItem
for theFlatListItem
interface (the props are spread onto aListItem
element)items.length
for no results, instead ofpageCount
div
for the secondary typography element, if the children is anything other than a string (helps with console warnings, DOM shouldn't be affected visually)ToolbarPageTitle
componentAlertAveragesGraph
to use thesx
prop for css instead of classes viamakeStyles
ISOPickers
to update the input value if the incoming value changesISOPickers
coloring UX (fixes icon color in dark mode)