-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: on call notification channel separation #3046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the layout:
- can we move the notification type selection below the notification options?
- The Slack channel for user groups is for errors/issues, not as a fallback (from a user perspective)
Also, this needs the behavioral change in the backend -- ensuring user group updates don't send the regular channel notification.
Just to clarify - no messages should be sent at all if there isn't an error updating the UG? |
Correct, if the notification channel is |
Good idea about the type field. And I made the types in all caps to stay in line with the personal contact method dropdown, which uses all caps. I'm fine with changing that to title case as well, but I think we should be consistent |
Good point, could probably be a small change in its own PR since it's on the profile too. When I go to create a duplicate user group, it only validates that the channel is the same (even though it's for error reporting). I think we should error on a duplicate user-group and set that as the first error to return if using that type, even if the channel for error messaging is different. This could also be a separate issue I think but we could maybe fix here. |
It will only show the error if both the user group and channel are the same as another existing rule. @mastercactapus says he thinks that's fine for now, and that we can refactor this in the future if we want to make the user group unique between rules. |
make check
to catch common errors. Fixed any that came up.Description:
Value
type forScheduleOnCallNotificationsForm
has been altered to be more accommodating of different notification channel typesYARN_VERSION
instead of assumed stable versionUsage Error: Invalid package manager specification in CLI arguments; expected a semver version
from recent build changesWhich issue(s) this PR fixes:
#3045
Screenshots:


If applicable, add some screenshots here.
Describe any introduced user-facing changes:
To use Slack User Groups for schedule on-call notifications, the user must select "SLACK USER GROUP" from the new dropdown instead of checking a checkbox.