Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove slack usergroup exp flag #3144

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

allending313
Copy link
Contributor

@allending313 allending313 commented Jul 5, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Removed slack user group experimental flag option. On call notifications will have slack user groups as an option by default as long as slack in enabled.

  • happy-path integration test, ensuring we can add a user group notification to a schedule
  • smoketest/compliance test ensuring a configured notification rule sends the intended notification

@github-actions github-actions bot added the size/s label Jul 5, 2023
mastercactapus
mastercactapus previously approved these changes Jul 5, 2023
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can also update schedules.cy.ts to not call testScreenWithFlags anymore

@github-actions github-actions bot added size/m and removed size/s labels Jul 5, 2023
@mastercactapus mastercactapus merged commit 1405360 into master Jul 6, 2023
@mastercactapus mastercactapus deleted the remove-slack-usergroup-expflag branch July 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants