Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add happy path integration test for on call notification webhook #3155

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat: add happy path integration test for on call notification webhook #3155

merged 3 commits into from
Jul 11, 2023

Conversation

allending313
Copy link
Contributor

@allending313 allending313 commented Jul 10, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Added additional cypress test ensuring that schedules on call notification UI works with webhooks

@allending313 allending313 requested a review from Forfold July 10, 2023 18:38
@allending313 allending313 merged commit 630a43a into master Jul 11, 2023
@allending313 allending313 deleted the webhook-integration-test branch July 11, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allending313 @mastercactapus @Forfold