-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add base admin API key support #3274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbenington
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and seems to work well locally
andrewbenington
suggested changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like expflag.d.ts
and schema.d.ts
are out of date, running go generate ./web/src
updated them for me
andrewbenington
approved these changes
Sep 14, 2023
KatieMSB
approved these changes
Sep 20, 2023
allending313
pushed a commit
that referenced
this pull request
Sep 27, 2023
* add api key tables * update schema for create and delete * manage keys * enforce api key fields * add new key type to auth * add usage query * regen * regen * cleanup field validation * set role * add role to API * remove cache for initial PR * add experimental flag * move migration * regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the ability to create, delete, and use admin-only API keys for the GraphQL API.
This functionality is behind the experimental flag
gql-api-keys
.make start EXPERIMENTAL=gql-api-keys
Which issue(s) this PR fixes:
Part of #3007
Out of Scope:
Describe any introduced API changes:
createGQLAPIKey
anddeleteGQLAPIKey
mutations were addedAdditional Context
Since this is a large PR, here's a walkthrough of the changes:
/api/graphql
and theGQLAPIKey
experimental flag must be enabledAroundFields
moddlewaregql_api_keys
table, with soft-deletesgql_api_key_usage
table, since it will receive frequent updates