-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Suspenseful loading #3440
Merged
Merged
ui: Suspenseful loading #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
reviewed
Nov 9, 2023
Forfold
reviewed
Nov 9, 2023
Forfold
previously approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's test in CI
Forfold
previously approved these changes
Nov 9, 2023
Forfold
reviewed
Nov 13, 2023
Forfold
previously approved these changes
Nov 13, 2023
KatieMSB
previously approved these changes
Nov 13, 2023
acd57e2
KatieMSB
approved these changes
Nov 13, 2023
Forfold
approved these changes
Nov 14, 2023
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the UI to enable
suspense
for allurql
queries.As components are migrated from apollo to urql, they will automatically get tracked by suspense.
Notably, boundaries were added:
RequireAuth
component (instead of the redux mess)The
QuerySelect
tool explicitly turns off suspenseful loading as it handles loading state internally and shouldn't trigger a page-level (or dialog-level) spin.Which issue(s) this PR fixes:
Part of #2557
Out of Scope:
fetching
/isLoading
logic will still need to be removed/cleaned up separatelyScreenshots:
suspense-demo-3.mp4
Describe any introduced user-facing changes:
urql
only)urql
(and any nested components doing so) will spin until all content is loadedDescribe any introduced API changes:
N/A
Additional Info:
With
suspense
enabled, auseQuery
will never returnfetching: true
you will always getdata
orerror
.