ui/message-logs: use a sane limit for the max num of graph points #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatieMSB
approved these changes
Nov 22, 2023
tony-tvu
approved these changes
Nov 22, 2023
|
should pass on rebuild now that it has the fix from master |
KatieMSB
approved these changes
Nov 22, 2023
|
What fix are you referring to @mastercactapus? Edit: Looks like he's referring to #3476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the limit from 1000 intervals on the graph to a max of 75. This still allows for weekly intervals for a full year (52) and all the minutes in an hour (60), but not by day for a full year (365), which is non-performant especially when segmentation is introduced in #3296, where more data is being loaded for each interval duration.