Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/urql: convert user dialogs to urql #3493

Merged
merged 12 commits into from
Jan 8, 2024
Merged

ui/urql: convert user dialogs to urql #3493

merged 12 commits into from
Jan 8, 2024

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Nov 29, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Migrates from @apollo/client to urql for the following files:

  • web/src/app/users/UserCreateDialog.tsx
  • web/src/app/users/UserDeleteDialog.tsx
  • web/src/app/users/UserEditDialog.tsx
  • web/src/app/users/UserNotificationRuleCreateDialog.tsx
  • web/src/app/users/UserNotificationRuleDeleteDialog.tsx

Which issue(s) this PR fixes:
Part of #3240

@KatieMSB KatieMSB mentioned this pull request Nov 29, 2023
Open
76 tasks
ethan-haynes
ethan-haynes previously approved these changes Dec 5, 2023
View reviewed changes
@KatieMSB KatieMSB requested a review from ethan-haynes December 5, 2023 21:35
Forfold
Forfold previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Forfold
Forfold previously approved these changes Dec 12, 2023
View reviewed changes
@github-actions github-actions bot added size/l and removed size/m labels Dec 13, 2023
Forfold
Forfold previously approved these changes Jan 4, 2024
View reviewed changes
mastercactapus
mastercactapus previously approved these changes Jan 8, 2024
View reviewed changes
@KatieMSB KatieMSB requested a review from Forfold January 8, 2024 16:42
@mastercactapus mastercactapus merged commit b8be7e2 into master Jan 8, 2024
@mastercactapus mastercactapus deleted the user-dialogs-urql branch January 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

@ethan-haynes ethan-haynes Awaiting requested review from ethan-haynes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatieMSB @mastercactapus @Forfold @ethan-haynes