-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add Service.RequiredLabels #3531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things that should be addressed:
- There's no validation on admin configs page for invalid label keys.
- There's no error message when editing a service config's label and submitting.
@tony-tvu good catch, I added the validation for Config and updated the form to display label value errors. you can validate it by adding trailing space to the value in one of the dialogs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more UX related topic, can we make it so we know that we are filling out a label when creating a service? Maybe have the field name be Service Label, and the actual set label can be a fixed left-adornment within the text field. Old: New: The FormField code for the new, if accepted: <FormField
...
label='Service Label'
InputProps={{
startAdornment: (
<InputAdornment position='start'>
{labelName}:
</InputAdornment>
),
}}
/> |
I'd like to switch to the adornment thing if we can figure out how to label the fields in a way that's not too repetitive |
I think I would be okay with it since each would have a unique adornment. Or if there's more than 1 we could put in the effort to make it like the admin config text field:
|
Description:
Adds a
Required Labels
field for services.Which issue(s) this PR fixes:
Part of #3425
Out of Scope:
Screenshots:


Describe any introduced user-facing changes:
Describe any introduced API changes:
N/A