app: don't sanitize search param for list pages #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more comments finish updating middleware method (oops)
mastercactapus
previously approved these changes
Jul 10, 2019
mastercactapus
approved these changes
Jul 11, 2019
m17ch
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR fixes an issue where search parameters were being sanitized on list pages, and which could lead to a broken state.
Which issue(s) this PR fixes:
On list pages, spaces at the end were forcefully being trimmed on the UI. In some situations, this could lead to the page being broken.
Describe any introduced user-facing changes:
Searching on list pages now allows spaces at the end/beginning on the backend. It basically takes the search parameters 'as it is' for searching. Forceful trimming is no longer observed.