Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: return fragments in favor of arrays #57

Merged
merged 2 commits into from
Jul 17, 2019
Merged

ui: return fragments in favor of arrays #57

merged 2 commits into from
Jul 17, 2019

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Jul 16, 2019

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Returns React.Fragments in place of [] with each index having an associated key. This is for code consistency.

Forfold added 2 commits July 2, 2019 10:57
@Forfold
return fragments in favor of arrays
3177fd3
@Forfold
Merge branch 'master' of https://github.com/target/goalert into tweak…
1cc09c9 
…-fragments

# Conflicts:
#	web/src/app/contact-methods/components/ContactMethodForm.js
Katy-M
Katy-M approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@Katy-M Katy-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Forfold Forfold merged commit aa5432b into master Jul 17, 2019
@Forfold Forfold deleted the tweak-fragments branch July 17, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@dayander dayander dayander approved these changes

@Katy-M Katy-M Katy-M approved these changes

@arurao arurao Awaiting requested review from arurao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Forfold @mastercactapus @dayander @Katy-M