Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Scanners At Startup, In Config Tests #306

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

ryanohoro
Copy link
Collaborator

Describe the change

work() in strelka.py now calls check_scanners() which attempts to import all scanners enabled in the configuration. Missing scanners will throw ModuleNotFoundError, but any exception will be raised, halting execution when strelka-backend is used.

A test src/python/strelka/tests_configuration/test_scanner_import.py was added that calls check_scanners() when CONFIG_TESTS=true is set.

ScanBITS was throwing an exception and was disabled in backend.yaml until it can be fixed.

ScanRuby was in backend.yaml but does not exist, and was removed.

Describe testing procedures
Describe the tests that you ran to verify your changes (including test configurations) and instructions so we can reproduce the tests. To assist in testing, the project maintainers may ask for file samples.

Sample output
If this change modifies Strelka's output, then please include a sample of the output here.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer merged commit 5883766 into target:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants