Check Scanners At Startup, In Config Tests #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
work()
instrelka.py
now callscheck_scanners()
which attempts to import all scanners enabled in the configuration. Missing scanners will throwModuleNotFoundError
, but any exception will be raised, halting execution whenstrelka-backend
is used.A test
src/python/strelka/tests_configuration/test_scanner_import.py
was added that callscheck_scanners()
when CONFIG_TESTS=true is set.ScanBITS was throwing an exception and was disabled in
backend.yaml
until it can be fixed.ScanRuby was in
backend.yaml
but does not exist, and was removed.Describe testing procedures
Describe the tests that you ran to verify your changes (including test configurations) and instructions so we can reproduce the tests. To assist in testing, the project maintainers may ask for file samples.
Sample output
If this change modifies Strelka's output, then please include a sample of the output here.
Checklist