Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate to Github Actions #3097

Merged
merged 2 commits into from
Jul 19, 2021
Merged

ci: migrate to Github Actions #3097

merged 2 commits into from
Jul 19, 2021

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Jul 14, 2021

Description

  • Switch CI to Github Actions

    1. CI workflow runs cargo fmt check and clippy, build on ubuntu/macos/windows, and test on ubuntu simultaneously example
    2. Test RFC docs on any PR example, and deploy RFC docs to gh-pages on any push to development branch (same as circle ci did) example / rendered
    3. Security audit - unchanged
    4. Binary builds - unchanged

  • Integration tests remain on Circle CI for now, there is a WIP version here that needs debugging

Motivation and Context

Consolidating CI with one provider as much as possible

How Has This Been Tested?

Github actions

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

[ci] Migrate to Github Actions
9648f1f 
- Switch CI to Github Actions
- Integration tests remain on Circle CI for now
SWvheerden
SWvheerden approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

.circleci/config.yml Show resolved Hide resolved
@delta1
Copy link
Contributor Author

delta1 commented Jul 15, 2021

Looks like the required status checks for the protected branch will need to be changed in the repo settings

image

@stringhandler stringhandler changed the title [ci] Migrate to Github Actions ci: migrate to Github Actions Jul 19, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Resource not accessible by integration

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Resource not accessible by integration

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 19, 2021

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Resource not accessible by integration

@stringhandler stringhandler merged commit 6b974d0 into tari-project:development Jul 19, 2021
@delta1 delta1 deleted the covert-actions branch July 19, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StriderDM StriderDM StriderDM left review comments

@stringhandler stringhandler stringhandler approved these changes

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delta1 @SWvheerden @stringhandler @StriderDM