chore: fix potentially buggy split of string into lines #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
previously approved these changes
Oct 27, 2022
@sdbondi DeepSource checked failed another one, do I need to fix it also? |
|
@hnidoaht-101 that check is new and currently not required |
hnidoaht-101
force-pushed
the
chore/fix-buggy-string-split
branch
from
110d71a to
d0b1f3d
Compare
CjS77
added
the
P-reviews_required
stringhandler
added
P-merge
CjS77
added
the
P-reviews_required
|
utACK |
|
If its okay, please do me a favor label it as "hacktoberfest-accepted" 😄 thank you. |
sdbondi
approved these changes
Oct 27, 2022
CjS77
removed
the
P-reviews_required
The repo already has the hacktoberfest topic label, so I think once your PR is merged it will count towards it 👌 |
Awesome! It seems I missed the label on repo 😅 , will continue looking for issues to resolve if possible |
|
Happy hacking @hnidoaht-101 |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 7, 2022
* development: (52 commits) chore: better help for seed-words command (tari-project#4885) fix(ci): resolve windows binary builds (tari-project#4883) fix(ci): correct ARM64 builds (tari-project#4876) fix(comms/peer_manager): fix possible panic in offline calc (tari-project#4877) feat!: impl final tari pow algorithm (tari-project#4862) fix(ci): selectively revert resolver for arm64 builds (tari-project#4871) chore(deps): bump actions/checkout from 2 to 3 (tari-project#4873) fix: delete orphans if they exist (tari-project#4868) chore: replace manual implementation of char methods (tari-project#4864) chore: fix potentially buggy split of string into lines (tari-project#4863) fix(ci): update GHA set-output plus dependabot schedule for GHA (tari-project#4857) fix(base-node): use less harsh emoji for unreachable node (tari-project#4855) fix(core): add txo version checks to async validator (tari-project#4852) feat: add static lifetime to emission amounts calculation (tari-project#4851) v0.38.8 feat: add opcode versions (tari-project#4836) fix: remove clear_on_drop dependency (tari-project#4848) fix(base-node): use Network::from_str to parse network in cli (tari-project#4838) ci: remove circleci test: add cucumber critical (tari-project#4823) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR served for fixing the bug described in #4809
Motivation and Context
Following the deepsource link in the issue above to fix.
How Has This Been Tested?