chore: prevent from clearing wallet data after restart #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please somebody test on win11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been clearing the wallet database on startup which forced scanning UTXOs from the tip 0 on every run. Scanning takes really long time each run:
Clearing was done when we had issues with view keys. Since it's gone, we can keep wallet dir and support caching.
How Has This Been Tested?
I tested manually by running the app several times and watching wallet logs(base_layer.log) to check whether wallet uses previously scanned blocks.
I also played with displaying seed words and importing new wallets to ensure everything is doesn't break anything related to the view keys