feat: add squad to p2pool #1371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stringhandler
commented
Jan 10, 2025
stringhandler
commented
- add squad to p2pool for telemetry
- change p2pool to latest version
- change minotari suite to latest version
- change p2pool stats to use tokio::watch instead of polling (this means fewer requests to p2pool)
brianp
reviewed
Jan 10, 2025
| warn!(target: LOG_TARGET, "Error getting p2pool stats: {}", e); | ||
| None | ||
| }); | ||
| let p2pool_stats = state.p2pool_latest_status.borrow().clone(); |
There was a problem hiding this comment.
I've seen some issues with the latest status caching. When you stop mining the last mining status will be cached, and continue to offer whatever stats were last given. Even if no longer connected. (This was fixed for the GPU miner before).
Just mentioning it here in case it's something that should be looked at in regards to p2p stats. Such as p2p is no longer connected but the cached stats have connected_since and makes everyone think it's still connected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.