Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix wallet address conversion to String #1031

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

igordanilcenko
Copy link
Contributor

There was a problem when addresses with 1-digit first HEX character were converted without "0".
For example 🌋 emoji has a "04" hex representation, but was converted as "4".

  • Forced to keep 2 characters for every byte of wallet address for String conversion.
  • Cleaned up constructor code of the HexString class

@igordanilcenko igordanilcenko merged commit 088a45d into release/0.25.0 Jan 23, 2024
1 check passed
@igordanilcenko igordanilcenko deleted the feature/address_to_hex_fix branch January 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants